Skip to content

ADDED $sortByPostion flag to getChildren() #11342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2017
Merged

ADDED $sortByPostion flag to getChildren() #11342

merged 5 commits into from
Oct 16, 2017

Conversation

denisristic
Copy link
Contributor

@denisristic denisristic commented Oct 10, 2017 •
edited by ishakhsuvarov
Loading

Method "getChildren" sort ordering (SQUASHTOBERFEST)

Description

ADDED $sortByPostion flag to getChildren()

Fixed Issues (if relevant)

  1. Method "getChildren" sort ordering #11310

@ishakhsuvarov ishakhsuvarov self-assigned this Oct 10, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 10, 2017
@ishakhsuvarov
Copy link
Contributor

@denisristic Please consider covering the updated behavior with integration test.

ADDED $sortByPosition flag to Magento\Catalog\Model\Category
f77dadb 
ADDED test testGetChildrenSroted() to integration testsuite Magento\Catalog\Model\Category
@sreichel sreichel mentioned this pull request Oct 11, 2017
Merged
Denis Ristic added 3 commits October 11, 2017 15:50
FIXED integration test
fc47234 
ADDED $recursive and $isActive, flags to getChildren()
FIXED sort
9d593a4
FIXED default getChildren() $recursive value
79693c8
@ishakhsuvarov ishakhsuvarov added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 13, 2017
@okorshenko okorshenko merged commit 79693c8 into magento:2.2-develop Oct 16, 2017
okorshenko pushed a commit that referenced this pull request Oct 16, 2017
MAGETWO-81456: ADDED $sortByPostion flag to getChildren() #11342
83a8ef5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ishakhsuvarov ishakhsuvarov

Labels

Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Milestone

October 2017

Development

Successfully merging this pull request may close these issues.

4 participants

@denisristic @ishakhsuvarov @magento-team @okorshenko